通过TiUP修改TiDB的isolation-read参数报错

[dasenlin]

tidb版本：4.0.7
参数：
server_configs:
tidb:
alter-primary-key: true
isolation-read.engines: tidb
log.file.max-size: 10
log.format: text
log.level: info
log.slow-threshold: 3000
split-region-max-num: 10000

reload报错
[tidb@tidb169 ~]$ tiup cluster reload tidb-test -R tidb
Starting component cluster: /home/tidb/.tiup/components/cluster/v1.2.0/tiup-cluster reload tidb-test -R tidb

• [ Serial ] - SSHKeySet: privateKey=/home/tidb/.tiup/storage/cluster/clusters/tidb-test/ssh/id_rsa, publicKey=/home/tidb/.tiup/storage/cluster/clusters/tidb-test/ssh/id_rsa.pub
• [Parallel] - UserSSH: user=tidb, host=10.181.85.169
• [Parallel] - UserSSH: user=tidb, host=10.181.85.168
• [Parallel] - UserSSH: user=tidb, host=10.181.85.165
• [Parallel] - UserSSH: user=tidb, host=10.181.85.166
• [Parallel] - UserSSH: user=tidb, host=10.181.85.162
• [Parallel] - UserSSH: user=tidb, host=10.181.85.163
• [Parallel] - UserSSH: user=tidb, host=10.181.85.167
• [Parallel] - UserSSH: user=tidb, host=10.181.85.161
• [Parallel] - UserSSH: user=tidb, host=10.181.85.160
• [Parallel] - UserSSH: user=tidb, host=10.181.85.169
• [Parallel] - UserSSH: user=tidb, host=10.181.85.164
• [Parallel] - UserSSH: user=tidb, host=10.181.85.169
• Refresh instance configs
  • Refresh config pd -> 10.181.85.166:2379 … Done
  • Refresh config pd -> 10.181.85.167:2379 … Done
  • Refresh config pd -> 10.181.85.168:2379 … Done
  • Refresh config tikv -> 10.181.85.163:20160 … Done
  • Refresh config tikv -> 10.181.85.164:20160 … Done
  • Refresh config tikv -> 10.181.85.165:20160 … Done
  • Refresh config tidb -> 10.181.85.161:4000 … Error
  • Refresh config tidb -> 10.181.85.162:4000 … Error
  • Refresh config tidb -> 10.181.85.160:4000 … Error
  • Refresh config prometheus -> 10.181.85.169:9090 … Done
  • Refresh config grafana -> 10.181.85.169:3000 … Done
  • Refresh config alertmanager -> 10.181.85.169:9093 … Done

Error: init config failed: 10.181.85.160:4000: executor.ssh.execute_failed: Failed to execute command over SSH for ‘tidb@10.181.85.160:22’ {ssh_stderr: , ssh_stdout: [2020/11/25 17:50:02.217 +08:00] [FATAL] [terror.go:257] [“unexpected error”] [error=“toml: cannot load TOML value of type string into a Go slice”] [stack=“github.com/pingcap/parser/terror.MustNil\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/pkg/mod/github.com/pingcap/parser@v0.0.0-20200921063432-e220cfcfd026/terror/terror.go:257\ github.com/pingcap/tidb/config.InitializeConfig\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/src/github.com/pingcap/tidb/config/config.go:759\ main.main\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/src/github.com/pingcap/tidb/tidb-server/main.go:165\ runtime.main\ \t/usr/local/go/src/runtime/proc.go:203”] [stack=“github.com/pingcap/parser/terror.MustNil\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/pkg/mod/github.com/pingcap/parser@v0.0.0-20200921063432-e220cfcfd026/terror/terror.go:257\ github.com/pingcap/tidb/config.InitializeConfig\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/src/github.com/pingcap/tidb/config/config.go:759\ main.main\ \t/home/jenkins/agent/workspace/tidb_v4.0.7/go/src/github.com/pingcap/tidb/tidb-server/main.go:165\ runtime.main\ \t/usr/local/go/src/runtime/proc.go:203”]
, ssh_command: export LANG=C; PATH=$PATH:/usr/bin:/usr/sbin /tidb-data/tidb-deploy/tidb-4000/bin/tidb-server --config-check --config=/tidb-data/tidb-deploy/tidb-4000/conf/tidb.toml }, cause: Process exited with status 1: check config failed

Verbose debug logs has been written to /home/tidb/logs/tiup-cluster-debug-2020-11-25-17-50-05.log.
Error: run /home/tidb/.tiup/components/cluster/v1.2.0/tiup-cluster (wd:/home/tidb/.tiup/data/SHLRsw2) failed: exit status 1

[zhenjiaogao]

@dasenlin

isolation-read.engines

1、Engine 隔离是通过配置变量来指定所有的查询均使用指定 engine 的副本，其中 “tidb” 表示 TiDB 内部的内存表区，主要用于存储一些 TiDB 系统表，用户不能主动使用。所以在设置该参数时，仅仅建议设置为 tikv 以及 tiflash，并且配置文件的配置为全局 instance 参数，如果仅仅设置为 tiflash，那么在默认情况下，所有的查询都会走 tiflash。所以，如果没有特别需求，可以通过 set session 的方式来临时的测试使用某个特定的 Engine，其他情况，建议设置为 tikv 以及 tiflash ，由优化器自动选择。语法参考 set SESSION tidb_isolation_read_engines = "逗号分隔的 engine list";

2、tiup 在修改配置文件参数 isolation-read.engines 时，建议使用下面的格式：
1）isolation-read.engines: [“xx”,“xx”]
2）请关注参数缩进，格式参考：